Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-sectorbuilder to latest that uses specs-actors types #121

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

We updated our internal types, but some of our dependencies updated as well -- this updates to use the go-sectorbuilder that uses specs-actors types

Implementation

Update -- FFI, go-sectorbuilder, & go-padreader

Also use abi.UnpaddedPieceSize where appropriate, and make appropriate conversion in deal PieceSize calculation

Copy link
Contributor

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward. I can only assume the Padded() func works from commP

@hannahhoward
Copy link
Collaborator Author

Padded() takes the pieceSize w/o bit padding (but w/ power of two 2 padding at the end) and returns the size w/ padding

@hannahhoward hannahhoward merged commit 2202549 into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants